Deeper URL path to health info #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added docker labels - improved consul-template install
|
|
||
| ``` | ||
| docker build --build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \ | ||
| --build-arg VCS_REF=`git rev-parse --short HEAD` . |
Contributor
There was a problem hiding this comment.
I guess your thought is that we'll add these via shippable.yml, rather than creating a new Makefile?
Contributor
There was a problem hiding this comment.
Is there any way to inject this info into a docker-compose build? The command line help doesn't suggest so. Maybe via the compose.yml file? If we break builds using docker-compose everywhere that's going to be very annoying for demos.
Contributor
|
LGTM except for my concerns in #18 (comment) |
This was referenced Jul 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deeper path reduces the risk of URL conflicts with other uses.
And...
If merged, this should be tagged as
1-r4