Merged
Conversation
mmcloughlin
approved these changes
Feb 14, 2024
Collaborator
mmcloughlin
left a comment
mmcloughlin
left a comment
There was a problem hiding this comment.
Thanks! Definitely better than doing major surgery I was attempting.
Approved with a question.
| pub const REG_WIDTH: usize = 64; | ||
|
|
||
| // Use a distinct with as the maximum width any value should have within type inference | ||
| pub const MAX_WIDTH: usize = 4*REG_WIDTH; |
Collaborator
There was a problem hiding this comment.
Is it worth limiting this to 2*REG_WIDTH at this point? Or do you think the width should have limited impact on solver performance?
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 9, 2024
Extends ISLE printer tests to cover `inst_specs.isle` and `prelude.isle`. Implements printing for const models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let us infer the types on larger bitwidths!