fix(security): redact clear-text logging of sensitive information#80
Closed
scottschreckengaust wants to merge 1 commit into
Closed
fix(security): redact clear-text logging of sensitive information#80scottschreckengaust wants to merge 1 commit into
scottschreckengaust wants to merge 1 commit into
Conversation
Potential fix for code scanning alert: "Clear-text logging of sensitive information" Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
Closing since fixed in #81 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/security/code-scanning/24
Best fix: harden
_debug_cwso it never logs raw free-form text; instead, apply stronger sanitization that masks known secret values and secret-like key/value patterns before printing or shipping to CloudWatch.Concretely in
agent/src/server.py:import re._redact_cached_credentialsimplementation with a stronger sanitizer that:GITHUB_TOKEN,LINEAR_API_TOKEN) when present.github_token=...,authorization: Bearer ...,secret=...,token=...,api_key=...,password=...) using regex.No functional flow changes are required; only log content sanitization is strengthened.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.