Skip to content

fix(security): redact clear-text logging of sensitive information #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scottschreckengaust wants to merge 1 commit into from
Closed

fix(security): redact clear-text logging of sensitive information #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion agent/src/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import contextlib as _ctx_for_debug
import logging
import os
import re
import threading
import time as _time_for_debug
import traceback
Expand All @@ -31,12 +32,27 @@


def _redact_cached_credentials(text: str) -> str:
"""Remove cached env secrets from debug text before stdout / CloudWatch."""
"""Remove sensitive material from debug text before stdout / CloudWatch."""
out = text

# 1) Redact exact cached secret values when present.
for env_key in ("GITHUB_TOKEN", "LINEAR_API_TOKEN"):
secret = os.environ.get(env_key) or ""
if len(secret) >= 12:
out = out.replace(secret, f"<{env_key}_REDACTED>")

# 2) Redact common secret-bearing key/value patterns.
secret_patterns = (
r"(?i)\b(github_token|linear_api_token|token|secret|api[_-]?key|password)\b\s*[:=]\s*([^\s,;]+)",
r"(?i)\b(authorization)\b\s*[:=]\s*(bearer\s+)?([^\s,;]+)",
)
for pattern in secret_patterns:
out = re.sub(
pattern,
lambda m: f"{m.group(1)}=<REDACTED>",
out,
)

return out


Expand Down
Loading