remove workaround from gitsecrets.yml#3958
Merged
Merged
Conversation
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
amogh09
approved these changes
Oct 11, 2023
SreeeS
approved these changes
Oct 11, 2023
danehlim
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The upstream issue with git secrets requiring "say" command has been fixed: awslabs/git-secrets#221
Implementation details
Removed the changes made in #3442
Testing
PR git secret workflow succeeds.
New tests cover the changes: no
Description for the changelog
enhancement: remove workaround from gitsecrets.yml
Does this PR include breaking model changes? If so, Have you added transformation functions?
noLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.