Only emit terminal codes to terminal (and don't require say)#221
Conversation
Check for presence of tput and for stdout being a terminal before emitting terminal control codes. Remove unnecessary dependence on `say`
9769e8c to
65891e2
Compare
|
It would be great to get some eyes on this PR, as we are sporadically hitting the problem of |
say)
|
Is @mtdowling still affiliated with this project? Your name is all over the blame from seven years ago. :) Trying to find some reviewers. |
Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
sparr
left a comment
There was a problem hiding this comment.
I pushed a commit to use command instead of which, but otherwise this is a great change that resolves outstanding test failures.
|
for those who are on MacOS and still encountering this problem, you'll need to use the |
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
the upstream issue with git secrets requiring "say" command has been fixed upstream: awslabs/git-secrets#221
|
Homebrew's git-secrets v1.3.0 still uses say command, so macOS users encounters VoiceOver's voice from your speaker when you run
|
Issue #, if available:
Fixes #220
Fixes #239
Description of changes:
say(which was removed: git/git@5b893f7)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.