Installation fails without a terminal

[dannysauer]

git-secrets/git-secrets

Line 208 in 80230af

say "$(tput setaf 2)✓$(tput sgr 0) Installed ${hook} hook to ${dest}"

There's no particularly good reason to depend on say and to require a valid terminal just to print out a green checkmark symbol upon successful installation. :)

Run git secrets --install
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
/usr/local/bin/git-secrets: line 208: say: command not found
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
/usr/local/bin/git-secrets: line 208: say: command not found
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
/usr/local/bin/git-secrets: line 208: say: command not found
Error: Process completed with exit code 127.

[cahrens]

As of about 5 days ago, I am suddenly hitting the problem of say not being installed (though oddly in our project it happens sporadically). Has anyone figured out a workaround to this problem?

[dannysauer]

A couple of workarounds:
You could ln -s "$(which echo)" say in your $PATH and this should continue working. :)
Or upgrade to my branch / apply the diff in the PR mentioned before running the install.

[cahrens]

@dannysauer unfortunately ln -s "$(which echo)" did not work. Thank you for the suggestion though!

[cahrens]

This is probably the cause: git/git@5b893f7

[dannysauer]

@cahrens the idea was to put say in your path, something like /usr/local/bin/say. :)

sudo ln -s "$(which echo)" /usr/local/bin/say

[Greg-Myers-SB]

Oh this explains why my Mac started reading the git-secrets out loud! 🤣
Since git no longer has a say command, when git-secrets is installing on MacOS, it now reads the secrets hook out via the voice over utility. Looks like I'm using git <= 2.37 until this is changed.

[kdenhartog]

for those who are on MacOS and still encountering this problem (where you get the voice over utility issue), you'll need to use the make install method of installation. The brew cask has not been updated yet.

[kees-closed]

This is probably the cause: git/git@5b893f7

It doesn't seem like AWS is going to adapt to this upstream git change? My RPM package doesn't build for some time and may be removed because the make test fails because of this as well.

[Greg-Myers-SB]

@kees-closed This issue was fixed in #221
You may be encountering a new bug or may not have the latest version available in your OS' repositories and if so it may be worth re-reporting with a specific reproduction for your instance.

[alvincrespo]

When I tried to do which echo on my Mac, I got the following:

which echo
echo: shell built-in command

To resolve this, I did type -a echo, which gave me:

echo is a shell builtin
echo is /bin/echo

I then symlinked it:

sudo ln -s "/bin/echo" /usr/local/bin/say

Now, when I run git secrets I no longer get yelled at:

git secrets --install -f
✓ Installed commit-msg hook to .git/hooks/commit-msg
✓ Installed pre-commit hook to .git/hooks/pre-commit
✓ Installed prepare-commit-msg hook to .git/hooks/prepare-commit-msg