Conversation
shruti0085
reviewed
Jul 31, 2025
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/AmazonQLspServerBuilder.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/AmazonQLspServerBuilder.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/util/AbapUtil.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/util/AbapUtil.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/editor/ActiveEditorChangeListener.java
Outdated
Show resolved
Hide resolved
| Object part = partRef.getPart(false); | ||
| if (part instanceof ITextEditor) { | ||
| handleEditorChange((ITextEditor) part); | ||
| } else if (part instanceof IEditorPart) { |
Contributor
There was a problem hiding this comment.
isnt ItextEditor as IEditorPart as well?
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/editor/ActiveEditorChangeListener.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/editor/ActiveEditorChangeListener.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/editor/ActiveEditorChangeListener.java
Outdated
Show resolved
Hide resolved
shruti0085
reviewed
Aug 5, 2025
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/AmazonQLspServerBuilder.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/AmazonQLspServerBuilder.java
Outdated
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/editor/ActiveEditorChangeListener.java
Show resolved
Hide resolved
plugin/src/software/aws/toolkits/eclipse/amazonq/lsp/editor/ActiveEditorChangeListener.java
Outdated
Show resolved
Hide resolved
| } else if (editorInput instanceof IFileEditorInput fileEditorInput) { | ||
| return fileEditorInput.getFile().getRawLocation().toOSString(); | ||
| var file = fileEditorInput.getFile(); | ||
| if (file.getRawLocation() == null && AbapUtil.isAbapFile(file)) { |
Contributor
There was a problem hiding this comment.
Also add a comment indicating that special handling is needed for abap files because we are referencing the cached location it is stored with ADT plugins.
Please add this.
| } | ||
|
|
||
| @Test | ||
| void isAdtEditorWithSapPackagePrefixReturnsTrue() { |
Contributor
There was a problem hiding this comment.
this test can be removed
plugin/tst/software/aws/toolkits/eclipse/amazonq/util/AbapUtilTest.java
Outdated
Show resolved
Hide resolved
shruti0085
reviewed
Aug 7, 2025
| private void setupPlatformMock() { | ||
| setupPlatformMockWithPaths( | ||
| "file:///workspace/.metadata/.plugins/org.eclipse.core.resources.semantic/.cache/test/path", | ||
| "/workspace/.metadata/.plugins/org.eclipse.core.resources.semantic", |
Contributor
There was a problem hiding this comment.
shouldnt this be c:/users instead?
shruti0085
approved these changes
Aug 7, 2025
shruti0085
added a commit
that referenced
this pull request
Aug 13, 2025
Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
The Amazon Q Eclipse plugin lacked proper support for ABAP files when used with the ADT (ABAP Development Tools) plugin. ABAP developers could not access inline completion suggestions or benefit from active file functionality that was available for other programming languages. The plugin was unable to recognize ABAP workspace structure and files, preventing Amazon Q features from working in ABAP development environments.
Solutions
This PR enables ABAP support by registering a new editor to handle ABAP files in the active file system and utilizing temporary folder management to make ABAP files accessible to Q chat functionality. The solution registers common ABAP files into the workspace so clients can utilize inline suggestions for ABAP development. This allows ABAP files to display the Q button for inline suggestions and be properly recognized by the Amazon Q system.
Further work
Future improvements should include
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.