Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line text with inline prompt
XiaoxuanLu
approved these changes
Aug 12, 2025
| composite.setLayout(new GridLayout(1, false)); | ||
|
|
||
| inputField = new Text(composite, SWT.SEARCH | SWT.BORDER | SWT.SINGLE); | ||
| inputField = new Text(composite, SWT.BORDER | SWT.MULTI); |
There was a problem hiding this comment.
For curiosity, why we want to delete SWT.SEARCH and change to MULTI?
Contributor
Author
There was a problem hiding this comment.
that is for addressing the second bug, it was blocking the ability to support multi line text inputs in the inline chat box
rli
reviewed
Aug 12, 2025
| for (var listener : listenersAfter) { | ||
| if (!listenersBefore.contains(listener)) { | ||
| if (isAdtPaintListener(listener)) { | ||
| paintListenerRef = listener; |
Contributor
Author
There was a problem hiding this comment.
not for adt. Adt wraps the paint listener into a PaintListenerDelagate which is an internal ADT class which then holds the reference of the PaintListener we create
rli
approved these changes
Aug 12, 2025
shruti0085
added a commit
that referenced
this pull request
Aug 13, 2025
Merges feature branch containing improvements for ADT ABAP support into main. Relevant PRs * adt support #487 * Support updating remote when ABAP files are edited #495 * handle the null case for contentType in adt plugin environment #496 * Fix: Handle removing paint listeners with ADT viewer and allow multiline text in inline chat #500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change addresses a few bugs:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.