Serialize code completion requests to LSP#514
Merged
Conversation
rli
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#511
Description of changes:
The LSP no longer supports concurrent completion requests and will effectively drop concurrent requests. Eclipse's implementation was designed to 'fire and forget' and thus important requests are now being lost. This change reworks the logic to constrain a single completion request to be processed at any given time, and queues the latest request to be subsequently processed (dropping any intermediates in the interim). Goal to to process only the latest, most relevant suggest request whilst allowing an in-flight request to gracefully complete with the appropriate LSP callback.
Some additional refactoring to make this component (very) slightly less unreadable. Also added additional logic to ignore rendering if the character carat position has changed to avoid out-of-place suggestions being rendered in the new location.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.