-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Support multiple linting rules #9859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple linting rules #9859
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## upgrade-linting-tool #9859 +/- ##
=====================================================
Coverage 93.33% 93.33%
=====================================================
Files 209 209
Lines 16807 16807
=====================================================
Hits 15687 15687
Misses 1120 1120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just a note, the pagination linting rule should actually be based around the |
kdaily
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice work so far! Mostly a few basic comments and suggestions.
I think the biggest feedback is the main() method is quite long and a bit hard to follow. I would recommend breaking it out into a few helpers to clarify the branching behavior a bit better.
Description of changes:
'refreshed'. We avoid this problem by linting the script one-rule-at-a-time.
Base64BinaryFormatRuleso that it does not requirefile://prefix in an argument value to trigger a detection. It now flags all AWS CLI commands.PaginationRulethat flags all AWS CLI commands, and adds--no-cli-paginateas a fix.ScriptLinterclass with utility functions. Updated their interface to let callers pass in their own AST.PaginationRule.Description of tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.