Skip to content

Conversation

@aemous
Copy link
Contributor

@aemous aemous commented Dec 18, 2025

Description of changes:

  • Added 23 more linting rules to the linter with auto-fix behavior:
    • High-level s3 copies. Adds --copy-props none to the command.
    • CloudFormation deploy commands that rely on default behavior for empty changesets. Adds --fail-on-empty-changeset to the command.
    • Use of hidden aliases. Replaces the hidden alias with the original modeled parameter.
  • Update pagination linting rule to be based on --no-cli-pager flag. (details)
  • Add new tests to test new behavior added in this PR, and updated existing tests based on updates to existing functionality.

Description of tests:

  • Ran and passed all tests.
  • Manually tested different modes on example scripts, verifying the new linting rules are working as exected.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested a review from a team December 18, 2025 19:02
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.33%. Comparing base (d90bfde) to head (c2db7d0).
⚠️ Report is 6 commits behind head on upgrade-linting-tool.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           upgrade-linting-tool    #9936   +/-   ##
=====================================================
  Coverage                 93.33%   93.33%           
=====================================================
  Files                       209      209           
  Lines                     16807    16807           
=====================================================
  Hits                      15687    15687           
  Misses                     1120     1120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hssyoo hssyoo self-requested a review December 22, 2025 20:09
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@aemous aemous merged commit ceef794 into aws:upgrade-linting-tool Dec 23, 2025
48 checks passed
aemous added a commit that referenced this pull request Jan 5, 2026
Includes all changes from #9803, #9859, #9936, #9948, and #9953.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants