test: fix start-lambda-no-containers test #8490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix start-lambda-no-containers test and move the creation of the local Lambda client to a separate function
Which issue(s) does this change fix? / Why is this change necessary?
TestFunctionNameFilteringWarmContainersLazy::test_no_containers_before_invoke_with_lazytest has been failing because it finds one running container even though it shouldn't find any. This happens because another test from the same class does create containers, so then this test finds the containers from that other test. This test-separation should be handled by the variablemode_env_variable, which allows the check to only find the containers from this class. <- yes, from this class. The hash is created once per class, so the containers in all the tests on the same class will share the hash.How does it address the issue?
Split the tests into different classes, so they have different
mode_env_variablevalues, and the container count works correctly.What side effects does this change have?
Nothing. More classes.
I also split the creation of the local Lambda client (used to invoke the local server), which was being done inside every class manually. Now it's a unified method that gets called without any parameter, instead of having the build all the parameters from the client every time.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.