Skip to content

Conversation

@valerena
Copy link
Contributor

@valerena valerena commented Dec 5, 2025

Pin Ruby action to specific version until Lambda Buidlers support bundler 4.0.0

Which issue(s) does this change fix?

SAM CLI integration tests use a ruby GitHub action to set up ruby to check that building ruby works correctly. However, Lambda Builders doesn't support bundler 4.0.0 yet. So the tests are failing when trying to use the latest version.

Why is this change necessary?

Integ tests are failing without this

How does it address the issue?

Pins the version of ruby GitHtub action, to before they updated to use bundler 4.0.0
diff: ruby/setup-ruby@v1.268.0...v1.269.0

What side effects does this change have?

None

Mandatory Checklist

PRs will only be reviewed after checklist is complete

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pin Ruby action to specific version until Lambda Buidlers support
`bundler` 4.0.0
@valerena valerena requested a review from a team as a code owner December 5, 2025 23:48
@vicheey vicheey enabled auto-merge December 6, 2025 00:16
@vicheey vicheey disabled auto-merge December 6, 2025 00:16
@vicheey vicheey enabled auto-merge December 6, 2025 00:16
@vicheey vicheey closed this Dec 6, 2025
auto-merge was automatically disabled December 6, 2025 00:19

Pull request was closed

@vicheey vicheey reopened this Dec 6, 2025
@vicheey vicheey enabled auto-merge December 6, 2025 00:20
@vicheey vicheey closed this Dec 6, 2025
auto-merge was automatically disabled December 6, 2025 00:31

Pull request was closed

@vicheey vicheey reopened this Dec 6, 2025
Copy link
Member

@roger-zhangg roger-zhangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the integration test.

@valerena valerena closed this Dec 8, 2025
@valerena valerena reopened this Dec 8, 2025
@valerena valerena added this pull request to the merge queue Dec 8, 2025
Merged via the queue into aws:develop with commit dc0de29 Dec 8, 2025
91 checks passed
reedham-aws added a commit to reedham-aws/aws-sam-cli that referenced this pull request Dec 17, 2025
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants