Skip to content

Conversation

@YuCao16
Copy link
Contributor

@YuCao16 YuCao16 commented Jul 30, 2023

  1. toggleterm.nvim: fix toggleterm start_in_insert not working.
  2. diffview.nvim: disable lsp diagnostics in Diffview mode, otherwise, lsp goes crazy due to the conflict markers (<<<) and then crashes.

@ayamir
Copy link
Owner

ayamir commented Jul 31, 2023

  1. Can't repro on my wsl.
  2. What you introduced is set in the default setup function as diffview.nvim's readme said.

@YuCao16
Copy link
Contributor Author

YuCao16 commented Jul 31, 2023

  1. Can't repro on my wsl.
  2. What you introduced is set in the default setup function as diffview.nvim's readme said.
  1. Are you using 0.10, because I'm gussing it's a nightly issue for autocmd.

  2. I ran into this problem yesterday and I thought it wasn't turned on by default, sorry about this. I will try to create a repro code and raise issue in diffview.

@ayamir
Copy link
Owner

ayamir commented Jul 31, 2023

No, I tested it for 0.9. You should open a pr for 0.10 branch instead of main.

@YuCao16
Copy link
Contributor Author

YuCao16 commented Jul 31, 2023

No, I tested it for 0.9. You should open a pr for 0.10 branch instead of main.

Sure, I will.

@YuCao16 YuCao16 closed this Jul 31, 2023
Jint-lzxy added a commit that referenced this pull request Aug 2, 2023
IMO this is a good patch (taken from #913) and should be merged

---
Co-authored-by: YuCao16 <yu.carl@outlook.com>
ayamir pushed a commit that referenced this pull request Aug 2, 2023
IMO this is a good patch (taken from #913) and should be merged

---
Co-authored-by: YuCao16 <yu.carl@outlook.com>
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Aug 2, 2023
IMO this is a good patch (taken from ayamir#913) and should be merged

---
Co-authored-by: YuCao16 <yu.carl@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants