fix(toggleterm): start_in_insert not working
#919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO this is a good patch (taken from #913) and should be merged --- Co-authored-by: YuCao16 <yu.carl@outlook.com>
Contributor
|
I initially assumed this to be an issue with the nightly version, but that's not the case. The start_in_insert doesn't work because persist_mode is set to true. persist_mode retains the mode from when you last exited toggleterm.nvim. If you exit the terminal using wincmd, then you would reenter in insert mode. In my case, I exit the terminal by pressing q after double-tapping . Consequently, toggleterm remembers that my previous mode was normal, and it sets the mode back to normal when I reenter toggleterm.
|
singlemancombat
pushed a commit
to singlemancombat/nvim-config
that referenced
this pull request
Aug 2, 2023
IMO this is a good patch (taken from ayamir#913) and should be merged --- Co-authored-by: YuCao16 <yu.carl@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO this is a good patch (taken from #913) and should be merged.