chore: remove test-generator agent and references; update docs and te…#17
Merged
chore: remove test-generator agent and references; update docs and te…#17
Conversation
…sts; align agent count to 8
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the test-generator agent from the MAP framework, reducing the agent count from 9 to 8 specialized agents. The removal includes cleaning up all references to test-generator across template files, fallback generators, MCP configurations, and documentation.
Key Changes
- Removed the
test-generator.mdtemplate file (1,175 lines deleted) - Removed the
create_test_generator_content()fallback generator function - Updated all agent counts from 9 to 8 across documentation
- Cleaned up MCP server mappings that referenced test-generator
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/mapify_cli/templates/agents/test-generator.md |
Deleted entire test-generator agent template |
src/mapify_cli/__init__.py |
Removed test-generator from fallback generators and MCP mappings |
tests/test_mapify_cli.py |
Updated test expectations from 9 to 8 agents |
src/mapify_cli/templates/agents/CHANGELOG.md |
Updated changelog to reflect test-generator removal |
presentation/*/03-workflow.md |
Updated workflow diagrams and documentation |
presentation/*/02-architecture.md |
Removed test-generator from architecture overview |
presentation/*/04-getting-started.md |
Updated playbook section counts from 9 to 10 |
presentation/en/01-introduction.md |
Updated playbook categories from 9 to 10 |
mcp_config.json |
Removed test-generator from agent_mcp_mappings |
docs/research/prompt-improvement-analysis.md |
Removed test-generator reference |
docs/reddit-analysis-improvements-CORRECTED.md |
Updated agent count from 9 to 8 |
docs/IMPROVEMENT-STATUS.md |
Removed test-generator section and updated counts |
Comments suppressed due to low confidence (1)
presentation/ru/03-workflow.md:1
- The workflow description changes (lines 5-27) introducing TaskDecomposer as step 0, Recitation Plan as step 2.5, and renumbering subsequent steps are unrelated to removing test-generator. The PR appears to combine multiple unrelated changes: removing test-generator, updating workflow numbering, changing logging event names (lines 223-236), and updating playbook categories. These should be separate PRs for clarity and easier review.
# Рабочий Процесс MAP Framework
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ``` | ||
|
|
||
| **9 Pattern Categories:** | ||
| **10 Pattern Categories:** |
There was a problem hiding this comment.
The change from 9 to 10 pattern categories appears unrelated to removing test-generator. The diff shows the count changing from 9 to 10 and a new category 'CLI_TOOL_PATTERNS' being added (line 183). This mixing of unrelated changes makes it difficult to understand what this PR is actually doing - is it removing test-generator or adding a new playbook category? Consider separating these into distinct PRs.
| **Mechanism:** | ||
|
|
||
| 1. **Step 3.1.3:** **Orchestrator** generates a fresh recitation plan before Actor runs | ||
| 1. **Step 2.5:** **Orchestrator** creates a recitation plan after TaskDecomposer |
There was a problem hiding this comment.
The workflow step renumbering from 3.1.3 to 2.5 is unrelated to the test-generator removal. This change, along with the mermaid diagram updates and logging event name changes, should be in a separate PR focused on workflow clarification rather than mixed with the agent removal.
Fixed documentation inconsistencies after test-generator removal: - Updated src/mapify_cli/__init__.py:1653 to show "8 agents" instead of "9 agents" - Updated docs/IMPROVEMENT-STATUS.md to reflect 8-agent architecture - Removed test-generator from agent statistics - Recalculated totals: 2,354 → 7,841 lines (+233% growth) - Added CHANGELOG.md entry for v1.2.1 documenting the removal All tests passing (53/53). Zero breaking changes. Resolves documentation-code divergence issues identified in code review.
azalio
added a commit
that referenced
this pull request
Feb 13, 2026
…-35) MEDIUM fixes: - #8: Remove dead RETRY_LOOP phase from orchestrator STEP_PHASES - #10: Fix plan path to branch-scoped .map/<branch>/task_plan_<branch>.md - #11: Fix findings path to branch-scoped .map/<branch>/findings_<branch>.md - #12: Remove references to non-existent ralph-loop-config.json - #13/#14: Rewrite map-resume to use step_state.json instead of progress.md - #15: Fix INIT_PLAN heading format (### ST-XXX with - **Status:** prefix) - #16: Fix regex in step_runner to match plan format (### heading, - **Status:**) - #17: Fix map-learn contradiction about automatic learning LOW fixes: - #9/#31: Document dual state file system (step_state.json vs workflow_state.json) - #19: Document intentional Evaluator/Reflector/Curator omission in map-efficient - #20: Fix line count reference (~150 → ~540 lines) - #21: Standardize all AskUserQuestion to Python function call syntax - #22: Rename Steps 2.5/2.6 to 2a/2b to avoid phase number collision - #23/#24: Fix map-debate comparison table (map-efficient uses single Actor) - #25: Replace cat commands with Read tool comments in map-check - #28/#29: Replace undefined thrashing_detected()/max_redecompositions - #30: Add - **Status:** pending field to map-plan template - #32: Note map-fast max 3 vs map-efficient max 5 intentional difference - #33: Remove Evaluator from map-fast skipped agents list - #34: Move AskUserQuestion to "Built-in Tools" section in map-release - #35: Replace parallel bash & processes with sequential && in map-release Template sync: All .claude/ changes mirrored to src/mapify_cli/templates/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sts; align agent count to 8