fix(recitation): prefer playbook.db over playbook.json when both exist

[azalio]

Summary

Fixes issue where map-efficient (and other commands using RecitationManager) showed "Error reading file" for .claude/playbook.json despite the database already being migrated to .claude/playbook.db.

Problem

When both .claude/playbook.db and .claude/playbook.json existed, RecitationManager was incorrectly passing the JSON file path to PlaybookManager, causing it to attempt reading the deprecated JSON file even though the SQLite database was the current source of truth.

Solution

Updated RecitationManager initialization logic in src/mapify_cli/recitation_manager.py:

• Only pass playbook_path parameter if .db doesn't exist yet
• Prefer .db if it exists, only fall back to .json for migration
• Maintain backward compatibility with JSON-only setups

Changes

• Modified: src/mapify_cli/recitation_manager.py (line 562)
  • Changed condition from playbook_json_path.exists() to not playbook_db_path.exists() and playbook_json_path.exists()
• Added: tests/test_recitation_playbook_db_fix.py
  • Test DB preference when both files exist
  • Test migration still works when only JSON exists
  • Test graceful handling of missing playbook

Test Results

All 3 new tests pass:

• ✅ test_recitation_prefers_db_over_json
• ✅ test_recitation_migrates_json_to_db_when_only_json_exists
• ✅ test_recitation_handles_missing_playbook_gracefully

All existing playbook/recitation tests still pass (210 tests).

Verification

# Test the fix works
mapify recitation get-context  # No longer shows JSON read error

# Run new tests
pytest tests/test_recitation_playbook_db_fix.py -v

# Run all related tests
pytest tests/ -k "playbook or recitation" -v

Related

• Migration logic in PlaybookManager.__init__() already handles JSON→SQLite migration correctly
• This fix ensures RecitationManager doesn't interfere with that logic

[Copilot]

Pull Request Overview

This PR fixes an issue where RecitationManager was incorrectly attempting to read playbook.json even when playbook.db already existed, causing unnecessary migration attempts. The fix ensures that when both files exist, only the database file is used.

• Modified the playbook_path parameter logic in RecitationManager.generate_context_md() to only pass the JSON path when the database doesn't exist
• Added comprehensive test coverage for three scenarios: preferring DB over JSON, migrating JSON to DB, and handling missing playbooks

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/mapify_cli/recitation_manager.py	Updated PlaybookManager instantiation to prefer .db file and only pass playbook_path when migration is needed
tests/test_recitation_playbook_db_fix.py	Added new test file with three test cases covering DB preference, migration, and graceful handling of missing files

Comments suppressed due to low confidence (1)

tests/test_recitation_playbook_db_fix.py:8

• Import of 'tempfile' is not used.

import tempfile

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.