fix: add missing +x to runtime env toolchain interpreter script#2086
Merged
rickeylev merged 10 commits intobazel-contrib:mainfrom Jul 24, 2024
Merged
fix: add missing +x to runtime env toolchain interpreter script#2086rickeylev merged 10 commits intobazel-contrib:mainfrom
rickeylev merged 10 commits intobazel-contrib:mainfrom
Conversation
aignas
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
runtime_env_toolchain_interpreter.shfile was missing the executable bit, which prevented the file from actually be runnable later.To fix, just
chmod +xit. I also added tests to actually run using it and verify thatit is the toolchain used by the test.
Fixes #2085