Pass py_binary data deps through to underlying binary.#60
Pass py_binary data deps through to underlying binary.#60optimality wants to merge 1 commit intobazelbuild:masterfrom optimality:add-data-dep
Conversation
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I think this would fix an issue I ran into. It looks like without this change, the data deps to py_appengine_binary get silently dropped. |
|
Can someone take a look at this merge it in? It looks like a pretty trivial fix. A workaround in the meantime is to create a separate py_library and put the data argument on that. Then include that py_library as a dep to py_appengine_binary. |
|
Can one of the admins verify this patch? |
pmbethe09
left a comment
There was a problem hiding this comment.
passing the data deps LGTM, but the 'style fixes' are not appropriate, this is skylark not python.
https://docs.bazel.build/versions/master/skylark/bzl-style.html
Also, CLA not signed yet.
| native.py_binary( | ||
| name="_py_appengine_" + name, | ||
| srcs = srcs, | ||
| srcs=srcs, |
There was a problem hiding this comment.
This is not a cleanup. Skylark style has spaces around '=' which is different than python
|
FWIW, I noticed the lack of 'data = data' while working on #71 and my PR includes the same fix. |
Also cleaning up the style a bit.