Skip to content
This repository was archived by the owner on Dec 15, 2023. It is now read-only.

Pass py_binary data deps through to underlying binary. #60

Closed
optimality wants to merge 1 commit into from
+5 −4
Closed

Pass py_binary data deps through to underlying binary. #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions appengine/py_appengine.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,9 @@ def py_appengine_binary(name, srcs, configs, deps=[], data=[]):
# uses py_binary because it generates __init__.py files
native.py_binary(
name="_py_appengine_" + name,
srcs = srcs,
srcs=srcs,
Copy link
Contributor

@pmbethe09 pmbethe09 Feb 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a cleanup. Skylark style has spaces around '=' which is different than python

deps=deps,
data=data,
main=srcs[0], # no entry point, use arbitrary source file
)
py_appengine_binary_base(
Expand All @@ -209,9 +210,9 @@ def py_appengine_binary(name, srcs, configs, deps=[], data=[]):
configs=configs,
)
native.sh_binary(
name = "%s.deploy" % name,
srcs = ["%s_deploy.sh" % name],
data = [name],
name="%s.deploy" % name,
srcs=["%s_deploy.sh" % name],
data=[name],
)

def py_appengine_library(**kwargs):
Expand Down