Adds support for bindeps in crate universe#2226
Merged
UebelAndre merged 2 commits intobazelbuild:mainfrom Oct 31, 2023
csmulhern:main
Merged
Adds support for bindeps in crate universe#2226UebelAndre merged 2 commits intobazelbuild:mainfrom csmulhern:main
UebelAndre merged 2 commits intobazelbuild:mainfrom
csmulhern:main
Conversation
Collaborator
|
I think this looks good! Just gotta fix up the new test and rebase 😄 |
UebelAndre
approved these changes
Oct 31, 2023
Collaborator
|
Ah, there's one more directory which needs to be repinned via crate_universe. Try running the following? cd ./test/no_std/ && REPIN=1 bazel query //... |
illicitonion
approved these changes
Oct 31, 2023
Collaborator
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Looks great, thanks!
Contributor
Author
Bah, thanks. Happy we were able to land this. Thanks all! |
UebelAndre
pushed a commit
that referenced
this pull request
Oct 31, 2023
Followup to #2226. That PR made bindeps work for crates repositories that use `manifests`. https://github.com/bazelbuild/rules_rust/blob/d86faee8b85cc334e0529193142f4b61362e79a3/examples/crate_universe/WORKSPACE.bazel#L60 This PR makes it work for crates repositories that use `packages`. https://github.com/bazelbuild/rules_rust/blob/43b101e6b3e679b333c2622d7615233edf344624/examples/crate_universe/WORKSPACE.bazel#L317-L320
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1739, #2031, #2168.