Skip to content

Support artifact dependencies in crate.spec#2229

Merged
UebelAndre merged 4 commits intobazelbuild:mainfrom
dtolnay-contrib:bindepspec
Oct 31, 2023
Merged

Support artifact dependencies in crate.spec#2229
UebelAndre merged 4 commits intobazelbuild:mainfrom
dtolnay-contrib:bindepspec

Conversation

@dtolnay
Copy link
Copy Markdown
Contributor

@dtolnay dtolnay commented Oct 31, 2023

Followup to #2226. That PR made bindeps work for crates repositories that use manifests.

manifests = ["//cargo_bindeps:Cargo.toml"],

This PR makes it work for crates repositories that use packages.

"cxxbridge-cmd": crate.spec(
artifact = "bin",
version = "1.0.109",
),

Copy link
Copy Markdown
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit 841a733 into bazelbuild:main Oct 31, 2023
@dtolnay dtolnay deleted the bindepspec branch October 31, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants