Make rust analyzer aspect follow rust_test.crate attribute#751
Make rust analyzer aspect follow rust_test.crate attribute#751hlopko merged 6 commits intobazelbuild:mainfrom
Conversation
2515d40 to
a82d193
Compare
|
CC @djmarcin |
I pass a path to rust-project.json as a command line arg to the test.
Now that I'm forced to think about this more, I found alternatives:
I'm inclined to pursue the runfiles alternative (but I think the harness PR still makes sense and can go in). |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
@googlebot I fixed it. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
7127fe1 to
da8b3ab
Compare
|
And finally we have a green CI. PTAL :) |
UebelAndre
left a comment
There was a problem hiding this comment.
This looks good to me! a small nit and one question that's more of an aside 😅
|
This looks good to me! Feel free to merge whenever you'd like 😄 and thanks! |
Before, generated rust-project.json did not contain dependencies from the
rust_librarywhenrust_testused.crateattribute and the test was the only root in thetargetsattribute ofrust_analyzerrule.This PR depends on #754 and #760.