Skip to content

Add support for manifest based runfiles.#760

Merged
hlopko merged 4 commits intobazelbuild:mainfrom
hlopko:runfiles
Jun 2, 2021
Merged

Add support for manifest based runfiles.#760
hlopko merged 4 commits intobazelbuild:mainfrom
hlopko:runfiles

Conversation

@hlopko
Copy link
Copy Markdown
Member

@hlopko hlopko commented Jun 1, 2021

These are typically used on Windows when using symlinks which are needed
for directory based runfiles is not possible.

Fixes #616.

@google-cla google-cla Bot added the cla: yes label Jun 1, 2021
@hlopko hlopko requested review from UebelAndre, dfreese and mfarrugi June 1, 2021 20:30
Copy link
Copy Markdown
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise looks good to me!

Comment thread tools/runfiles/runfiles.rs
hlopko added 3 commits June 2, 2021 08:54
These are typically used on Windows when using symlinks which are needed
for directory based runfiles is not possible.
@hlopko hlopko merged commit b8219ac into bazelbuild:main Jun 2, 2021
@hlopko hlopko deleted the runfiles branch June 2, 2021 07:09
hlopko added a commit that referenced this pull request Jun 9, 2021
Before, generated rust-project.json did not contain dependencies from the `rust_library` when `rust_test` used `.crate` attribute and the test was the only root in the `targets` attribute of `rust_analyzer` rule.

This PR depends on #754 and #760.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable //tools/runfiles on the Windows CI

3 participants