Merged
Conversation
- clean unused files - reorder module imports - not tested
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces new mutational signature analysis capabilities by adding SigProfilerMatrixGenerator integration and removes deprecated components. The main purpose is to modernize the signature analysis workflow with more robust matrix generation tools.
- Add MAF to VCF conversion and SigProfilerMatrixGenerator processes for comprehensive signature matrix generation
- Remove deprecated MSIGHDP process and related HDP signature extraction components
- Reorganize workflow imports and clean up code structure
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/deepcsa.nf | Integrates new MAF2VCF and SIGPROMATRIXGENERATOR processes, reorganizes imports |
| modules/local/maf2vcf/main.nf | New process to convert MAF files to VCF format |
| modules/local/signatures/sigprofiler/matrixgenerator/main.nf | New process for generating signature matrices using SigProfilerMatrixGenerator |
| modules/local/signatures/msighdp/main.nf | Removes deprecated MSIGHDP process |
| subworkflows/local/signatures/main.nf | Removes MSIGHDP references and commented code |
| subworkflows/local/signatures_hdp/main.nf | Cleans up commented code in HDP workflow |
| conf/modules.config | Adds configuration for new MAF2VCF and SIGPROMATRIXGENERATOR processes |
Comments suppressed due to low confidence (1)
modules/local/signatures/sigprofiler/matrixgenerator/main.nf:1
- The command construction lacks proper quoting around variables that could contain spaces or special characters. Consider wrapping variables like ${prefix}, ${genome}, and ${args} in quotes to prevent issues with special characters.
process SIGPROFILER_MATRIXGENERATOR {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SigProfilerMatrixGenerator to get DBS and ID matrices with the filtered mutations and also some simple plots.
Tested
AI summary
This pull request introduces new modules for mutational signature analysis and integrates them into the main workflow. The key changes are the addition of
MAF_2_VCFandSIGPROFILER_MATRIXGENERATORprocesses, their configuration and wiring in the pipeline, and the removal of the deprecatedMSIGHDPprocess. There are also some cleanups and reorganization in the workflow files.New modules and integration for mutational signature analysis:
MAF_2_VCFprocess to convert MAF files to VCF format, including Docker container specification, input/output handling, and version reporting (modules/local/maf2vcf/main.nf).SIGPROFILER_MATRIXGENERATORprocess for generating mutational signature matrices from VCF files, with support for multiple output types and genome assemblies (modules/local/signatures/sigprofiler/matrixgenerator/main.nf).MAF_2_VCFandSIGPROFILER_MATRIXGENERATORinto the main workflow, wiring their inputs and outputs and updating the pipeline logic to support signature analysis (workflows/deepcsa.nf) [1] [2] [3].Configuration updates for new processes:
MAF2VCFandSIGPROMATRIXGENERATORinconf/modules.config, specifying arguments and publish directories [1] [2].Deprecation and cleanup:
MSIGHDPprocess and its references from the codebase, including subworkflow and workflow files (modules/local/signatures/msighdp/main.nf,subworkflows/local/signatures/main.nf,subworkflows/local/signatures_hdp/main.nf) [1] [2] [3] [4] [5].Workflow and code organization:
workflows/deepcsa.nf) [1] [2].These changes collectively modernize and extend the pipeline's signature analysis capabilities while removing unused legacy code.