Skip to content

Conversation

@stephen
Copy link
Contributor

@stephen stephen commented Dec 10, 2014

Currently, this works, but isn't entirely satisfying. There's no way to watch for future changes in logical groupings.

@stephen stephen changed the title [WIP] Basic logical search (single callback) [WIP] Logical device search Dec 10, 2014
@stephen stephen added this to the 1.0.0 Release milestone Dec 10, 2014
@stephen stephen mentioned this pull request Dec 10, 2014
7 tasks
@stephen
Copy link
Contributor Author

stephen commented Jan 9, 2015

Note to self: things that apply for bridge probably also apply for the new BOOST thing.

@stephen
Copy link
Contributor Author

stephen commented Feb 15, 2015

Going to merge this as an interim step towards device group watching, unless objections.

@stephen stephen changed the title [WIP] Logical device search Logical device search Feb 15, 2015
@bencevans
Copy link
Owner

No objections here

On Sun, 15 Feb, 2015 at 9:07 AM, Stephen Wan notifications@github.com
wrote:

Going to merge this as an interim step towards device group watching,
unless objections.


Reply to this email directly or view it on GitHub.

@tonycoco
Copy link

Mergeable yet? Ping to @stephen @bencevans

@bencevans
Copy link
Owner

It's on the list of things to do. I hope I'm able to get to play with this soon but if someone else is able to review and check that this works, that'd be brilliant then we'll get it merged in 👍

@vkoi81
Copy link

vkoi81 commented Jun 15, 2015

@bencevans
I had an issue with my devices showing up twice but after making the change nraamat suggested, I no longer have the problem with duplicates.

I'm just a newbie so can't verify the code is written to the best it can be but it worked for me.

Thanks.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is called every time a device is initialized and causes the search to return a full list of devices multiple times.

See stephen#1. Sorry I just saw this PR, I should've pulled into @stephen's logical-search branch

@svrooij
Copy link
Collaborator

svrooij commented Jan 5, 2018

@stephen could you have a look if you still want to merge this?

@svrooij svrooij removed this from the 1.0.0 Release milestone Jan 16, 2018
@svrooij
Copy link
Collaborator

svrooij commented Jan 17, 2018

This request seems stall, talked to @bencevans and we decided to close it.

In the new async version there is a ZoneGroup event, that could be used to find out changes in groups if you want to give it a new go.

@svrooij svrooij closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants