Fixed async usage to only invoke LogicalDevice.search callback when a… #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll device initializations have completed.
This was referenced Jun 25, 2015
Owner
|
Nice find!
|
stephen
added a commit
that referenced
this pull request
Aug 9, 2015
Fixed async usage to only invoke LogicalDevice.search callback when a…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll device initializations have completed.
The async.each usage here is causing the LogicalDevice.search callback to be invoked after every device initialization. Added an async.each callback, following the async 0.9.2 source, to call LogicalDevice.search callback when all iterations are complete.