Conversation
Merged
Contributor
|
@tomMoral can you just disable a solver with a local config file? |
Member
We used to have this feature but it was deemed too early and I removed it ^^' |
Contributor
|
let's KISS
… |
Member
|
Not sure that this is simple and stupid to have to remove and re-add solver when the dependencies breaks instead of editing a file... |
Collaborator
Author
|
Let's say we spend time on it if the issue pops up another time ? |
Member
|
Agreed it is not the priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They will release a new version where this is fixed around mid-december (CEA-COSMIC/ModOpt#169).
In the meantime, I propose to remove this solver as it's a pain to use benchopt commands when this one is present.