Allow #[derive(Bundle)] on tuple structs (take 3)#10561
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Nov 21, 2023
Merged
Allow #[derive(Bundle)] on tuple structs (take 3)#10561alice-i-cecile merged 6 commits intobevyengine:mainfrom
alice-i-cecile merged 6 commits intobevyengine:mainfrom
Conversation
Member
SET001
commented
Nov 14, 2023
SET001
commented
- rework of old @Veykril's work in 2499
- Fixes 3537
alice-i-cecile
added
A-ECS
MrGVSV
reviewed
Nov 14, 2023
nicopap
reviewed
Nov 16, 2023
Contributor
nicopap
left a comment
nicopap
left a comment
There was a problem hiding this comment.
Looks good. Just need to move the test.
nicopap
approved these changes
Nov 17, 2023
Member
Author
|
are there any places in docs that should be updated to these changes? |
alice-i-cecile
approved these changes
Nov 19, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
I would be happy to see this added to a doc test in the Bundle derive code, but that's definitely not blocking. |
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
- rework of old @Veykril's work in [2499](bevyengine#2499) - Fixes [3537](bevyengine#3537)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.