Allow #[derive(Bundle)] on tuple structs (take 2)#3634
Closed
dataphract wants to merge 1 commit intobevyengine:mainfrom
Closed
Allow #[derive(Bundle)] on tuple structs (take 2)#3634dataphract wants to merge 1 commit intobevyengine:mainfrom
dataphract wants to merge 1 commit intobevyengine:mainfrom
Conversation
james7132
added
A-ECS
alice-i-cecile
approved these changes
Jan 11, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Looks good! Some more comments on this derive macro would help with maintainability in the future, but this PR doesn't make the existing situation any worse (and adds nice tests).
20 tasks
dataphract
force-pushed
the
feat/bundle-tuple-struct
branch
from
cd57e5e to
dcd4cb9
Compare
Co-authored-by: dataphract <dataphract@gmail.com>
dataphract
force-pushed
the
feat/bundle-tuple-struct
branch
from
dcd4cb9 to
052014c
Compare
Member
|
So... it seems this PR was missed but is still needed... @dataphract are you ready for take 3? |
superdump
added
the
S-Adopt-Me
Member
|
fixed with 10561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rebase of @Veykril's work in #2499 onto the latest main. Fixes #3537.