[Merged by Bors] - Xtask CI#1387
Closed
CleanCut wants to merge 6 commits intobevyengine:mainfrom
CleanCut:xtask
Closed
[Merged by Bors] - Xtask CI#1387CleanCut wants to merge 6 commits intobevyengine:mainfrom CleanCut:xtask
CleanCut wants to merge 6 commits intobevyengine:mainfrom
CleanCut:xtask
Conversation
…, so there's only one place to update.
Member
Author
|
❓ Odd, this works for me locally with both stable and nightly...but CI doesn't seem to find the .cargo/config file. I'll look into this tomorrow night unless someone beats me to it. Update: I ended up punting and running the task without using the alias in CI. |
bjorn3
reviewed
Feb 3, 2021
bjorn3
reviewed
Feb 3, 2021
Merged
MinerSebas
reviewed
Feb 9, 2021
alice-i-cecile
added
the
A-Build-System
CleanCut
added
C-Feature
Member
|
I dig this. I'm definitely looking forward to consistent (and easy to run) ci validation. Resolve merge conflicts and we're good to go!. |
Member
Author
|
✅ Resolved |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2021
This PR is easiest to review commit by commit. Followup on #1309 (comment) - [x] Switch from a bash script to an xtask rust workspace member. - Results in ~30s longer CI due to compilation of the xtask itself - Enables Bevy contributors on any platform to run `cargo ci` to run linting -- if the default available Rust is the same version as on CI, then the command should give an identical result. - [x] Use the xtask from official CI so there's only one place to update. - [x] Bonus: Run clippy on the _entire_ workspace (existing CI setup was missing the `--workspace` flag - [x] Clean up newly-exposed clippy errors ~#1388 builds on this to clean up newly discovered clippy errors -- I thought it might be nicer as a separate PR.~ Nope, merged it into this one so CI would pass. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is easiest to review commit by commit.
Followup on #1309 (comment)
cargo cito run linting -- if the default available Rust is the same version as on CI, then the command should give an identical result.--workspaceflag#1388 builds on this to clean up newly discovered clippy errors -- I thought it might be nicer as a separate PR.Nope, merged it into this one so CI would pass.