Fix errors exposed by cargo ci on nightly#1388
Closed
CleanCut wants to merge 2 commits intobevyengine:masterfrom
CleanCut:nightly-clippy
Closed
Fix errors exposed by cargo ci on nightly#1388CleanCut wants to merge 2 commits intobevyengine:masterfrom CleanCut:nightly-clippy
cargo ci on nightly#1388CleanCut wants to merge 2 commits intobevyengine:masterfrom
CleanCut:nightly-clippy
Conversation
…, so there's only one place to update.
…test nightly Rust.
Member
Author
|
Closing this in favor of merging the same fix into #1387 so it can pass CI. |
bors bot
pushed a commit
that referenced
this pull request
Feb 22, 2021
This PR is easiest to review commit by commit. Followup on #1309 (comment) - [x] Switch from a bash script to an xtask rust workspace member. - Results in ~30s longer CI due to compilation of the xtask itself - Enables Bevy contributors on any platform to run `cargo ci` to run linting -- if the default available Rust is the same version as on CI, then the command should give an identical result. - [x] Use the xtask from official CI so there's only one place to update. - [x] Bonus: Run clippy on the _entire_ workspace (existing CI setup was missing the `--workspace` flag - [x] Clean up newly-exposed clippy errors ~#1388 builds on this to clean up newly discovered clippy errors -- I thought it might be nicer as a separate PR.~ Nope, merged it into this one so CI would pass. Co-authored-by: Carter Anderson <mcanders1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When runningcargo ciwith the current nightly Rust, a bunch of bleeding-edge clippy things show up. Since we encourage people to use nightly, it makes sense to fix those too, even though official CI is on stable.I originally thought the new clippy errors that turned up were due to a difference in nightly vs stable, but upon closer inspection I believe a big factor is that we are now passing
--workspaceto clippy, where we were not before. Whatever the case, this PR cleans them all up.This builds on #1387