bug: Fix 9-slice textures with asymmetric borders.#13921
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Jun 19, 2024
Merged
bug: Fix 9-slice textures with asymmetric borders.#13921alice-i-cecile merged 4 commits intobevyengine:mainfrom
alice-i-cecile merged 4 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Jun 19, 2024
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good fix, great writeup. I'm happy with the tests: I want to to start making progress on testing rendering and UI, and for the most part this sort of thing is about as good as it gets.
alice-i-cecile
added
C-Bug
mockersf
approved these changes
Jun 19, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Jun 21, 2024
# Objective Fix a 9-slice asymmetric border issue that [QueenOfSquiggles](https://blobfox.coffee/@queenofsquiggles/112639035165575222) found. Here's the behavior before: <img width="340" alt="the-bug" src="https://github.com/bevyengine/bevy/assets/54390/81ff1847-b2ea-4578-9fd0-af6ee96c5438"> ## Solution Here's the behavior with the fix. <img width="327" alt="the-fix" src="https://github.com/bevyengine/bevy/assets/54390/33a4e3f0-b6a8-448e-9654-1197218ea11d"> ## Testing I used QueenOfSquiggles [repo](https://github.com/QueenOfSquiggles/my-bevy-learning-project) to exercise the code. I manually went through a number of variations of the border and caught a few other issues after the first pass. I added some code to create random borders and though they often looked funny there weren't any gaps like before. ### Unit Tests I did add some tests to `slicer.rs` mostly as an exploratory programming exercise. So they currently act as a limited, incomplete, "golden-file"-ish approach. Perhaps they're not worth keeping. In order to write the tests, I did add a `PartialEq` derive for `TextureSlice`. I only tested these changes on macOS. --- ## Changelog Make 9-slice textures work with asymmetric borders.
This was referenced Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix a 9-slice asymmetric border issue that QueenOfSquiggles found. Here's the behavior before:
Solution
Here's the behavior with the fix.
Testing
I used QueenOfSquiggles repo to exercise the code. I manually went through a number of variations of the border and caught a few other issues after the first pass. I added some code to create random borders and though they often looked funny there weren't any gaps like before.
Unit Tests
I did add some tests to
slicer.rsmostly as an exploratory programming exercise. So they currently act as a limited, incomplete, "golden-file"-ish approach. Perhaps they're not worth keeping.In order to write the tests, I did add a
PartialEqderive forTextureSlice.I only tested these changes on macOS.
Changelog
Make 9-slice textures work with asymmetric borders.