fix asymmetrical 9-slicing#14148
Merged
alice-i-cecile merged 6 commits intobevyengine:mainfrom Aug 1, 2024
JJJimbo1:main
Merged
fix asymmetrical 9-slicing#14148alice-i-cecile merged 6 commits intobevyengine:mainfrom JJJimbo1:main
alice-i-cecile merged 6 commits intobevyengine:mainfrom
JJJimbo1:main
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
S-Needs-Review
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
The fix looks good to me, but I'm not keen on how fragile this code is. Can you devise some tests for this module, including a regression test?
alice-i-cecile
added
S-Waiting-on-Author
Contributor
Author
|
I believe the tests introduced in #13921 adequately cover this. Let me know if they don't and I'll write more extensive tests. |
alice-i-cecile
approved these changes
Jul 7, 2024
alice-i-cecile
added
S-Needs-Review
alice-i-cecile
added
the
D-Straightforward
TrialDragon
approved these changes
Aug 1, 2024
TrialDragon
added
S-Ready-For-Final-Review
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
# Objective Fixes #14147. ## Solution Modify the slicing checks and algorithm to fully allow asymmetrical textures to work. Some opinionated code cleanup. ## Testing Tested using the ui_texture_slice example and a custom asymmetrical texture. Before:  After:  --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #14147.
Solution
Modify the slicing checks and algorithm to fully allow asymmetrical textures to work.
Some opinionated code cleanup.
Testing
Tested using the ui_texture_slice example and a custom asymmetrical texture.
Before:
After:
