Fix bevy_window failing with serialize feature#14298
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Jul 15, 2024
Merged
Fix bevy_window failing with serialize feature#14298alice-i-cecile merged 4 commits intobevyengine:mainfrom
bevy_window failing with serialize feature#14298alice-i-cecile merged 4 commits intobevyengine:mainfrom
Conversation
BD103
added
C-Bug
benfrankel
approved these changes
Jul 14, 2024
Contributor
benfrankel
left a comment
benfrankel
left a comment
There was a problem hiding this comment.
I only read the PR description and reviewed the code diff. Have not investigated whether this is correct or the potential implications.
MrGVSV
approved these changes
Jul 14, 2024
MrGVSV
added
S-Ready-For-Final-Review
Member
Author
|
@alice-i-cecile should the bug fix be backported to 0.14.1? If so, I should probably split this into two different PRs. |
Member
|
Yes, please split this for backporting. |
alice-i-cecile
added
S-Waiting-on-Author
This reverts commit 35fbbcc.
BD103
added
S-Ready-For-Final-Review
mnmaita
approved these changes
Jul 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 15, 2024
# Objective - Extracted from #14298. - `bevy_window` has an empty `default` feature that does not enable anything, which is equivalent to not having any default features. ## Solution - Remove it :) - This is technically a breaking change, but specifying `features = ["default"]` manually in `Cargo.toml` is highly discouraged, so the impact is low. --- ## Migration Guide `bevy_window` had an empty default feature flag that did not do anything, so it was removed. You may have to remove any references to it if you specified it manually. ```toml # 0.14 [dependencies] bevy_window = { version = "0.14", default-features = false, features = ["default"] } # 0.15 [dependencies] bevy_window = { version = "0.15", default-features = false } ```
mockersf
pushed a commit
that referenced
this pull request
Aug 2, 2024
# Objective - [`flag-frenzy`](https://github.com/TheBevyFlock/flag-frenzy) found an issue where `bevy_window` would fail to build when its `serialize` feature is enabled. - See [here](https://github.com/TheBevyFlock/flag-frenzy/actions/runs/9924187577/job/27415224405) for the specific log. ## Solution - Turns out it was failing because the `bevy_ecs/serialize` feature was not enabled. This error can be fixed by adding the flag as a dependency. ## Testing ```bash cargo check -p bevy_window -F serialize # Or if you're very cool... flag-frenzy --manifest-path path/to/bevy/Cargo.toml --config config -p bevy_window ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
flag-frenzyfound an issue wherebevy_windowwould fail to build when itsserializefeature is enabled.Solution
bevy_ecs/serializefeature was not enabled. This error can be fixed by adding the flag as a dependency.Testing
cargo check -p bevy_window -F serialize # Or if you're very cool... flag-frenzy --manifest-path path/to/bevy/Cargo.toml --config config -p bevy_window