Skip to content

Remove unused default feature from bevy_window#14313

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
BD103:rm-window-default-feature
Jul 15, 2024
Merged

Remove unused default feature from bevy_window#14313
alice-i-cecile merged 2 commits intobevyengine:mainfrom
BD103:rm-window-default-feature

Conversation

@BD103
Copy link
Member

@BD103 BD103 commented Jul 14, 2024

Objective

Solution

  • Remove it :)
    • This is technically a breaking change, but specifying features = ["default"] manually in Cargo.toml is highly discouraged, so the impact is low.

Migration Guide

bevy_window had an empty default feature flag that did not do anything, so it was removed. You may have to remove any references to it if you specified it manually.

# 0.14
[dependencies]
bevy_window = { version = "0.14", default-features = false, features = ["default"] }

# 0.15
[dependencies]
bevy_window = { version = "0.15", default-features = false }

@BD103 BD103 added D-Trivial Nice and easy! A great choice to get started with Bevy A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 14, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 14, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 15, 2024
@alice-i-cecile alice-i-cecile removed this pull request from the merge queue due to a manual request Jul 15, 2024
@alice-i-cecile
Copy link
Member

@BD103 this will need to have merge conflicts resolved in a bit :) Ping me when it's ready again.

@BD103
Copy link
Member Author

BD103 commented Jul 15, 2024

@alice-i-cecile done!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 15, 2024
Merged via the queue into bevyengine:main with commit 5ea8889 Jul 15, 2024
@BD103 BD103 deleted the rm-window-default-feature branch July 15, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Trivial Nice and easy! A great choice to get started with Bevy M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants