refactor(render): move WgpuWrapper into bevy_utils#19303
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom May 27, 2025
Merged
refactor(render): move WgpuWrapper into bevy_utils#19303alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
tychedelia
approved these changes
May 20, 2025
bushrat011899
suggested changes
May 20, 2025
Contributor
bushrat011899
left a comment
bushrat011899
left a comment
There was a problem hiding this comment.
Minor changes for no_std compatibility (in case someone activates the atomics feature on wasm32v1-none for example). Otherwise, I think this is a good idea.
Contributor
|
Just need to update line 24 of - std = ["alloc", "bevy_platform/std", "dep:thread_local"]
+ std = ["alloc", "bevy_platform/std", "dep:thread_local", "dep:send_wrapper"] |
bushrat011899
added
C-Code-Quality
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
Contributor
Author
|
I don't believe this needs a migration guide, WgpuWrapper wasn't exposed before. |
bushrat011899
removed
the
M-Migration-Guide
Contributor
|
My mistake! I saw that it was |
atlv24
added
S-Ready-For-Final-Review
Member
|
@atlv24 merge conflicts, sorry! |
atlv24
added a commit
to atlv24/bevy
that referenced
this pull request
Jul 21, 2025
atlv24
added a commit
to atlv24/bevy
that referenced
this pull request
Jul 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 21, 2025
# Objective - the changes done in #19303 did not end up being necessary for bevy_camera, because i found a better split. it was still a good refactor, but lets leave it in bevy_render ## Solution - partially revert by moving the extracted file to bevy_render ## Testing - it compiles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing