[Merged by Bors] - Replace .insert_resource(T::default()) calls with init_resource::<T>()#2807
Closed
MinerSebas wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Replace .insert_resource(T::default()) calls with init_resource::<T>()#2807MinerSebas wants to merge 1 commit intobevyengine:mainfrom
.insert_resource(T::default()) calls with init_resource::<T>()#2807MinerSebas wants to merge 1 commit intobevyengine:mainfrom
Conversation
DJMcNab
added
C-Code-Quality
DJMcNab
approved these changes
Sep 11, 2021
IceSentry
approved these changes
Sep 12, 2021
NiklasEi
approved these changes
Sep 12, 2021
NiklasEi
added
the
S-Ready-For-Final-Review
VVishion
approved these changes
Sep 12, 2021
Member
|
Awesome. Very cool to see |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2021
…T>()` (#2807) # Objective I added the [INSERT_RESOURCE_WITH_DEFAULT](https://minersebas.github.io/bevy_lint/bevy_lint/static.INSERT_RESOURCE_WITH_DEFAULT.html) Lint to [bevy_lint](https://github.com/MinerSebas/bevy_lint) and while Testing it on bevy itself, I found several places where the Lint correctly triggered. ## Solution Replace `.insert_resource(T::default())` calls with `init_resource::<T>()`
Contributor
|
Build failed: |
Contributor
Author
mockersf
approved these changes
Sep 13, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 13, 2021
…T>()` (#2807) # Objective I added the [INSERT_RESOURCE_WITH_DEFAULT](https://minersebas.github.io/bevy_lint/bevy_lint/static.INSERT_RESOURCE_WITH_DEFAULT.html) Lint to [bevy_lint](https://github.com/MinerSebas/bevy_lint) and while Testing it on bevy itself, I found several places where the Lint correctly triggered. ## Solution Replace `.insert_resource(T::default())` calls with `init_resource::<T>()`
Contributor
bors
bot
changed the title
.insert_resource(T::default()) calls with init_resource::<T>().insert_resource(T::default()) calls with init_resource::<T>()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
I added the INSERT_RESOURCE_WITH_DEFAULT Lint to bevy_lint and while Testing it on bevy itself, I found several places where the Lint correctly triggered.
Solution
Replace
.insert_resource(T::default())calls withinit_resource::<T>()