[Merged by Bors] - Fix the new nightly CI errors#2811
Closed
DJMcNab wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Fix the new nightly CI errors#2811DJMcNab wants to merge 2 commits intobevyengine:mainfrom
DJMcNab wants to merge 2 commits intobevyengine:mainfrom
Conversation
DJMcNab
added
A-ECS
Weibye
approved these changes
Sep 12, 2021
IceSentry
approved these changes
Sep 12, 2021
Contributor
IceSentry
left a comment
IceSentry
left a comment
There was a problem hiding this comment.
This fixes the issue, but I feel like this is a false positive on clippy side. The field was used here.
MinerSebas
approved these changes
Sep 12, 2021
Member
|
Relevant: rust-lang/rust#88900 |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2021
# Objective - CI is failing again - These failures result from rust-lang/rust#85200 ## Solution - Fix the errors which result from this by using the given fields - I also removed the now unused `Debug` impl. I suspect that we shouldn't use -D warnings for nightly CI - ideally we'd get a discord webhook message into some (non-#github) dedicated channel on warnings. But this does not implement that.
Contributor
bors
bot
changed the title
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Debugimpl.I suspect that we shouldn't use -D warnings for nightly CI - ideally we'd get a discord webhook message into some (non-#github) dedicated channel on warnings.
But this does not implement that.