Closed
Conversation
danieleades
commented
Dec 31, 2021
| let mut v = (0..10000).collect::<Vec<usize>>(); | ||
| c.bench_function("for_each_iter", |b| { | ||
| b.iter(|| { | ||
| v.iter_mut().for_each(|x| { |
Contributor
Author
There was a problem hiding this comment.
i'm suddenly realising that the point of this bench test is to bench the for_each function...
i'll add an explicit "allow" here
danieleades
force-pushed
the
refactor/benches
branch
from
297312b to
a0dfea4
Compare
mockersf
added
C-Code-Quality
alice-i-cecile
approved these changes
Jan 1, 2022
Member
|
Looking at the changes, it probably won't have any impacts, but did you try running the benches before / after? |
Contributor
Author
i didn't, no. As you say, there are no changes here that could affect performance |
danieleades
force-pushed
the
refactor/benches
branch
from
a0dfea4 to
6fa7c60
Compare
alice-i-cecile
approved these changes
Jan 4, 2022
danieleades
force-pushed
the
refactor/benches
branch
from
6fa7c60 to
0df7132
Compare
danieleades
force-pushed
the
refactor/benches
branch
from
0df7132 to
e27e31a
Compare
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
@danieleades these changes rock and we overlooked them, sorry. This is about to conflict massively with #5110; can you update this PR after that? If you're too busy just let us know and I'll get someone else to tackle it. |
alice-i-cecile
added
A-Diagnostics
bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
# Objective - #3505 marked `S-Adopt-Me` , this pr is to continue his work. ## Solution - run `cargo clippy --workspace --all-targets --all-features -- -Aclippy::type_complexity -Wclippy::doc_markdown -Wclippy::redundant_else -Wclippy::match_same_arms -Wclippy::semicolon_if_nothing_returned -Wclippy::explicit_iter_loop -Wclippy::map_flatten -Dwarnings` under benches dir. - fix issue according to suggestion.
Member
|
This pr should be closed as #6806 has been merged. @alice-i-cecile |
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - bevyengine#3505 marked `S-Adopt-Me` , this pr is to continue his work. ## Solution - run `cargo clippy --workspace --all-targets --all-features -- -Aclippy::type_complexity -Wclippy::doc_markdown -Wclippy::redundant_else -Wclippy::match_same_arms -Wclippy::semicolon_if_nothing_returned -Wclippy::explicit_iter_loop -Wclippy::map_flatten -Dwarnings` under benches dir. - fix issue according to suggestion.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - bevyengine#3505 marked `S-Adopt-Me` , this pr is to continue his work. ## Solution - run `cargo clippy --workspace --all-targets --all-features -- -Aclippy::type_complexity -Wclippy::doc_markdown -Wclippy::redundant_else -Wclippy::match_same_arms -Wclippy::semicolon_if_nothing_returned -Wclippy::explicit_iter_loop -Wclippy::map_flatten -Dwarnings` under benches dir. - fix issue according to suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i realised that my PR over at #2934 didn't include the
benches/crate. this PR covers that.