[Merged by Bors] - Fix clippy issue for benches crate#6806
Closed
lewiszlw wants to merge 3 commits intobevyengine:mainfrom
lewiszlw:fix-clippy-for-benches
Closed
[Merged by Bors] - Fix clippy issue for benches crate#6806lewiszlw wants to merge 3 commits intobevyengine:mainfrom lewiszlw:fix-clippy-for-benches
lewiszlw wants to merge 3 commits intobevyengine:mainfrom
lewiszlw:fix-clippy-for-benches
Conversation
james7132
added
C-Code-Quality
james7132
approved these changes
Dec 4, 2022
hymm
reviewed
Dec 11, 2022
danchia
approved these changes
Dec 11, 2022
alice-i-cecile
added
S-Ready-For-Final-Review
Member
|
This PR is mergeable in its current form, but the comments raised are valid and it'll be easier to do it here. @lewiszlw want to tackle it, or would you prefer I just merge? |
Member
Author
|
Resolved comments. @alice-i-cecile |
mockersf
reviewed
Dec 11, 2022
benches/benches/bevy_reflect/map.rs
Outdated
| for i in 0..size as u64 { | ||
| let key = black_box(i); | ||
| black_box(map.insert(key, i)); | ||
| map.insert(key, i); |
Member
Author
There was a problem hiding this comment.
black_box is a no-op according to hymm's comments, it should be deleted.
Member
There was a problem hiding this comment.
black_box(()); is a no-op, not sure about black_box(map); in this case. black boxes are used to avoid rust optimising out something. in this case it seems map is consumed by the closure, so I don't know if rust will optimise it out.
I'm not saying a black box is needed here, I don't know and am asking 🙂
mockersf
reviewed
Dec 11, 2022
| || s.clone_dynamic(), | ||
| |mut s| { | ||
| black_box(s.insert(black_box(&field), ())); | ||
| s.insert(black_box(&field), ()); |
Member
Author
There was a problem hiding this comment.
black_box is a no-op according to hymm's comments, it should be deleted.
Member
There was a problem hiding this comment.
black_box(()); is a no-op, not sure about black_box(s) in this case
alice-i-cecile
added
S-Ready-For-Final-Review
Member
|
Waiting for more clarity on the points raised above. |
Member
|
@lewiszlw could you re-add those black box calls to this PR so we can merge it and investigate the matter elsewhere? |
Member
Author
|
Re-added. Do I need to create an issue to track this? |
alice-i-cecile
approved these changes
Jan 11, 2023
Member
That would be lovely :) bors r+ |
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
# Objective - #3505 marked `S-Adopt-Me` , this pr is to continue his work. ## Solution - run `cargo clippy --workspace --all-targets --all-features -- -Aclippy::type_complexity -Wclippy::doc_markdown -Wclippy::redundant_else -Wclippy::match_same_arms -Wclippy::semicolon_if_nothing_returned -Wclippy::explicit_iter_loop -Wclippy::map_flatten -Dwarnings` under benches dir. - fix issue according to suggestion.
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
This was referenced Jan 11, 2023
Closed
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - bevyengine#3505 marked `S-Adopt-Me` , this pr is to continue his work. ## Solution - run `cargo clippy --workspace --all-targets --all-features -- -Aclippy::type_complexity -Wclippy::doc_markdown -Wclippy::redundant_else -Wclippy::match_same_arms -Wclippy::semicolon_if_nothing_returned -Wclippy::explicit_iter_loop -Wclippy::map_flatten -Dwarnings` under benches dir. - fix issue according to suggestion.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - bevyengine#3505 marked `S-Adopt-Me` , this pr is to continue his work. ## Solution - run `cargo clippy --workspace --all-targets --all-features -- -Aclippy::type_complexity -Wclippy::doc_markdown -Wclippy::redundant_else -Wclippy::match_same_arms -Wclippy::semicolon_if_nothing_returned -Wclippy::explicit_iter_loop -Wclippy::map_flatten -Dwarnings` under benches dir. - fix issue according to suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
S-Adopt-Me, this pr is to continue his work.Solution
cargo clippy --workspace --all-targets --all-features -- -Aclippy::type_complexity -Wclippy::doc_markdown -Wclippy::redundant_else -Wclippy::match_same_arms -Wclippy::semicolon_if_nothing_returned -Wclippy::explicit_iter_loop -Wclippy::map_flatten -Dwarningsunder benches dir.