Prevent WGPU from re-initializing depth buffer#3777
Closed
robojeb wants to merge 4 commits intobevyengine:mainfrom
Closed
Prevent WGPU from re-initializing depth buffer#3777robojeb wants to merge 4 commits intobevyengine:mainfrom
robojeb wants to merge 4 commits intobevyengine:mainfrom
Conversation
If a render pass is added after the "main_transparent_pass_3d" then WGPU will decide to re-initialize the depth buffer. This prevents subsequent render passes from rendering properly.
Contributor
Author
|
@superdump was involved with the discussion on Discord which resulted in this PR. |
james7132
added
A-Rendering
superdump
requested changes
Jan 27, 2022
Co-authored-by: Robert Swain <robert.swain@gmail.com>
Contributor
|
Just noting that @HackerFoo has also changed this here: #3552 |
superdump
reviewed
Jan 27, 2022
Contributor
superdump
left a comment
superdump
left a comment
There was a problem hiding this comment.
I think this now looks good, I'd just like to see what happens with #3552 when the merge train opens up as I expect a bunch of those PRs to go through. This commentary is very useful context though so we'll probably want it anyway. That said, this PR will probably be easier to rebase. :)
Contributor
Author
|
Sounds good, I will await further information. |
Member
|
Just a heads up, #3552 has been merged. Should this be revisited? |
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a render pass is added after the "main_transparent_pass_3d" then WGPU will decide to re-initialize the depth buffer.
This prevents subsequent render passes from rendering properly.
Objective
Fixes #3776
Solution
Unconditionally setting
store: truewill prevent WGPU from deciding that the Depth buffer is invalid if there is a subsequent render stage.This is slightly sub-optimal for performance in the base case, but makes behavior more expected when customizing the render graph.