[Merged by Bors] - Reuse texture when resolving multiple passes#3552
Closed
HackerFoo wants to merge 3 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Reuse texture when resolving multiple passes#3552HackerFoo wants to merge 3 commits intobevyengine:mainfrom
HackerFoo wants to merge 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-Rendering
Contributor
Author
|
It looks like the depth buffer is also not being shared by passes. |
Contributor
|
As #3412 was merged, could you update this on top of main so we can get it reviewed and merged? |
superdump
requested changes
Mar 6, 2022
Contributor
superdump
left a comment
superdump
left a comment
There was a problem hiding this comment.
Just need to update a comment and then this looks good to me.
alice-i-cecile
requested changes
Apr 3, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
A couple of nits, but the example and general code quality look good to me. Cannot comment in depth on the rendering strategy.
alice-i-cecile
approved these changes
Apr 4, 2022
Member
|
Sorry for the delay on this. This seems relatively uncontroversial / worth including in 0.7. I'll try to give it a proper review before release. |
mockersf
approved these changes
Apr 11, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
# Objective Fixes #3499 ## Solution Uses a `HashMap` from `RenderTarget` to sampled textures when preparing `ViewTarget`s to ensure that two passes with the same render target get sampled to the same texture. This builds on and depends on #3412, so this will be a draft PR until #3412 is merged. All changes for this PR are in the last commit.
Contributor
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective Fixes bevyengine#3499 ## Solution Uses a `HashMap` from `RenderTarget` to sampled textures when preparing `ViewTarget`s to ensure that two passes with the same render target get sampled to the same texture. This builds on and depends on bevyengine#3412, so this will be a draft PR until bevyengine#3412 is merged. All changes for this PR are in the last commit.
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
Because bevyengine#3552 got merged only switching the render order is left to fix bevyengine#3902
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Fixes bevyengine#3499 ## Solution Uses a `HashMap` from `RenderTarget` to sampled textures when preparing `ViewTarget`s to ensure that two passes with the same render target get sampled to the same texture. This builds on and depends on bevyengine#3412, so this will be a draft PR until bevyengine#3412 is merged. All changes for this PR are in the last commit.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
Because bevyengine#3552 got merged only switching the render order is left to fix bevyengine#3902
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #3499
Solution
Uses a
HashMapfromRenderTargetto sampled textures when preparingViewTargets to ensure that two passes with the same render target get sampled to the same texture.This builds on and depends on #3412, so this will be a draft PR until #3412 is merged. All changes for this PR are in the last commit.