[Merged by Bors] - scene viewer improvements: animation reset#4420
Closed
mockersf wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - scene viewer improvements: animation reset#4420mockersf wants to merge 1 commit intobevyengine:mainfrom
mockersf wants to merge 1 commit intobevyengine:mainfrom
Conversation
mockersf
added
C-Examples
Member
|
Tested this out, I like the changes! The movement speed here is slower than before on the flight helmet model, but I'm a fan of that change. |
alice-i-cecile
approved these changes
Apr 4, 2022
mockersf
force-pushed
the
restore-model-between-animations
branch
from
9a95a61 to
c03cac6
Compare
cart
reviewed
Apr 5, 2022
mockersf
force-pushed
the
restore-model-between-animations
branch
from
c03cac6 to
98ee0e1
Compare
mockersf
changed the title
alice-i-cecile
approved these changes
Apr 5, 2022
IceSentry
reviewed
Apr 6, 2022
IceSentry
approved these changes
Apr 6, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
# Objective - Changing animation mid animation can leave the model not in its original position - ~~The movement speed is fixed, no matter the size of the model~~ ## Solution - when changing animation, set it to its initial state and wait for one frame before changing the animation - ~~when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed~~
Contributor
|
Timed out. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
# Objective - Changing animation mid animation can leave the model not in its original position - ~~The movement speed is fixed, no matter the size of the model~~ ## Solution - when changing animation, set it to its initial state and wait for one frame before changing the animation - ~~when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed~~
Contributor
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
# Objective - Changing animation mid animation can leave the model not in its original position - ~~The movement speed is fixed, no matter the size of the model~~ ## Solution - when changing animation, set it to its initial state and wait for one frame before changing the animation - ~~when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed~~
Contributor
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
# Objective - Changing animation mid animation can leave the model not in its original position - ~~The movement speed is fixed, no matter the size of the model~~ ## Solution - when changing animation, set it to its initial state and wait for one frame before changing the animation - ~~when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed~~
Contributor
|
Timed out. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
# Objective - Changing animation mid animation can leave the model not in its original position - ~~The movement speed is fixed, no matter the size of the model~~ ## Solution - when changing animation, set it to its initial state and wait for one frame before changing the animation - ~~when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed~~
Contributor
bors
bot
changed the title
aevyrie
pushed a commit
to aevyrie/bevy
that referenced
this pull request
Jun 7, 2022
# Objective - Changing animation mid animation can leave the model not in its original position - ~~The movement speed is fixed, no matter the size of the model~~ ## Solution - when changing animation, set it to its initial state and wait for one frame before changing the animation - ~~when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed~~
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Changing animation mid animation can leave the model not in its original position - ~~The movement speed is fixed, no matter the size of the model~~ ## Solution - when changing animation, set it to its initial state and wait for one frame before changing the animation - ~~when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed~~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The movement speed is fixed, no matter the size of the modelSolution
when settings the camera controller, use the camera transform to know how far it is from the origin and use the distance for the speed