[Merged by Bors] - run examples on windows by mockersf · Pull Request #4437 · bevyengine/bevy

mockersf · 2022-04-07T08:19:35Z

Objective

~~Running examples on Linux in CI timeout~~Linux is back!
But hey we can run examples on windows too!

Solution

Run examples on windows daily
I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout)
And simplified the linux examples by not requiring a custom feature set

IceSentry · 2022-04-07T14:59:12Z

.github/workflows/ci.yml

-          sudo apt-get update
-          sudo apt install -y xvfb libegl1-mesa libgl1-mesa-dri libxcb-xfixes0-dev mesa-vulkan-drivers
      - uses: actions/checkout@v3
-      - uses: actions/cache@v3


Is there a reason for not using cache on windows?

mostly because I have no ideas how folders are organised on windows

I don't know if it's the case in the context of github runners, but as far as I know the paths in the linux run should be the same on windows. There's a ~ alias and windows supporst / so I think using the same paths should work.

alice-i-cecile · 2022-04-07T15:17:35Z

Added the Critical tag so we can merge things reliably. This LGTM (even if it is a bit of a hack), although I'm also curious about the cache.

alice-i-cecile · 2022-04-07T15:44:31Z

CI is mysteriously unbroken again, see #4420. I still think we should consider making these changes, in order to reduce the possible points of failure.

mockersf · 2022-04-07T15:48:52Z

I changed the PR to run examples on windows on a daily cron. It's still interesting to have the result, but not worth it to run it on every commit (and that way it'll be easy to copy/paste if there's a failure again)

IceSentry

LGTM

I wonder if there's other tests that could be moved to a daily only run to help make the PR pipeline faster. It's not a big issue and I guess at the speed we merge stuff it's better to make sure the PR is actually fully green.

alice-i-cecile · 2022-04-07T18:26:03Z

I wonder if there's other tests that could be moved to a daily only run

IMO we should try to run all of the examples daily on all platforms. I don't have a strong preference about whether that's done in this PR or a follow-up.

DJMcNab · 2022-04-15T11:29:26Z

I suspect the examples should be run on the bors try/staging commits too, even if not run on every commit within a PR?

For example, being able to minimise windows on windows is both quite an important property to preserve, and apparently an easy property to lose. Without this test we can't ensure that PR authors maintain this property; only get a failure in the (as far as I know) low-visibility daily run.

mockersf · 2022-04-27T11:29:43Z

windows and iOS won't run on a commit/PR, but will run on a bors command

mockersf · 2022-04-27T11:29:48Z

bors try

DJMcNab · 2022-04-27T11:31:29Z

Hopefully this try should fail, since #3597 should catch #4527

Unless you haven't rebased I guess, but it looks like you have

bors · 2022-04-27T11:53:43Z

try

Build failed:

run-examples-on-windows

mockersf · 2022-04-27T15:35:30Z

it failed on windows on the minimising example 🎉

alice-i-cecile · 2022-05-02T12:32:18Z

bors r+

# Objective - ~~Running examples on Linux in CI timeout~~Linux is back! - But hey we can run examples on windows too! ## Solution - Run examples on windows daily - I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout) - And simplified the linux examples by not requiring a custom feature set

bors · 2022-05-02T13:20:49Z

Build failed:

run-examples-on-windows

alice-i-cecile · 2022-05-02T13:25:35Z

bors r-

mockersf · 2022-05-02T13:53:03Z

blocked on #4527

mockersf · 2022-05-31T07:12:20Z

bors try

bors · 2022-05-31T07:34:30Z

try

Build succeeded:

alice-i-cecile · 2022-05-31T17:14:50Z

bors r+

# Objective - ~~Running examples on Linux in CI timeout~~Linux is back! - But hey we can run examples on windows too! ## Solution - Run examples on windows daily - I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout) - And simplified the linux examples by not requiring a custom feature set

bors · 2022-05-31T17:54:05Z

Pull request successfully merged into main.

Build succeeded:

# Objective - ~~Running examples on Linux in CI timeout~~Linux is back! - But hey we can run examples on windows too! ## Solution - Run examples on windows daily - I also added a 30 minutes timeout so that when it explodes, it doesn't explodes in 6 hours (the default timeout) - And simplified the linux examples by not requiring a custom feature set

IceSentry reviewed Apr 7, 2022

View reviewed changes

IceSentry added the A-Build-System Related to build systems or continuous integration label Apr 7, 2022

alice-i-cecile added the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Apr 7, 2022

alice-i-cecile approved these changes Apr 7, 2022

View reviewed changes

alice-i-cecile removed the P-Critical This must be fixed immediately or contributors or users will be severely impacted label Apr 7, 2022

IceSentry approved these changes Apr 7, 2022

View reviewed changes

alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 7, 2022

DJMcNab mentioned this pull request Apr 26, 2022

[Merged by Bors] - Add an example to test small window sizes #3597

Closed

mockersf force-pushed the run-examples-on-windows branch from e6728d0 to 12a925c Compare April 27, 2022 11:29

bors bot added a commit that referenced this pull request Apr 27, 2022

Try #4437:

ba2aacc

alice-i-cecile added the S-Blocked This cannot move forward until something else changes label May 2, 2022

mockersf added 4 commits May 7, 2022 00:00

run examples on windows

91d6213

adding timeout

f13827b

linux is back! but can be simplified

514f930

run windows daily

7e2aba6

mockersf added 7 commits May 7, 2022 00:01

last return

e441191

format

1b6e40d

cache on windows

9642744

adding jobs to bors

4ef4a11

remove android from common ci

43735cd

run all jobs on main

22a1e19

build wasm after normal build

0223cfc

mockersf force-pushed the run-examples-on-windows branch from ccc11b1 to 0223cfc Compare May 6, 2022 22:01

alice-i-cecile added the O-Windows Specific to the Windows desktop operating system label May 9, 2022

bors bot added a commit that referenced this pull request May 31, 2022

Try #4437:

74738f3

bors bot changed the title ~~run examples on windows~~ [Merged by Bors] - run examples on windows May 31, 2022

bors bot closed this May 31, 2022

Uh oh!

Conversation

mockersf commented Apr 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Uh oh!

IceSentry Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

mockersf Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

IceSentry Apr 7, 2022

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile commented Apr 7, 2022

Uh oh!

alice-i-cecile commented Apr 7, 2022

Uh oh!

mockersf commented Apr 7, 2022

Uh oh!

IceSentry left a comment

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile commented Apr 7, 2022

Uh oh!

DJMcNab commented Apr 15, 2022

Uh oh!

mockersf commented Apr 27, 2022

Uh oh!

mockersf commented Apr 27, 2022

Uh oh!

DJMcNab commented Apr 27, 2022

Uh oh!

bors bot commented Apr 27, 2022

try

Uh oh!

mockersf commented Apr 27, 2022

Uh oh!

alice-i-cecile commented May 2, 2022

Uh oh!

bors bot commented May 2, 2022

Uh oh!

alice-i-cecile commented May 2, 2022

Uh oh!

mockersf commented May 2, 2022

Uh oh!

mockersf commented May 31, 2022

Uh oh!

bors bot commented May 31, 2022

try

Uh oh!

alice-i-cecile commented May 31, 2022

Uh oh!

bors bot commented May 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mockersf commented Apr 7, 2022 •

edited

Loading