Replace many_for_each_mut with iter_many_mut.#5313
Closed
tim-blackbird wants to merge 0 commit intobevyengine:mainfrom
Closed
Replace many_for_each_mut with iter_many_mut.#5313tim-blackbird wants to merge 0 commit intobevyengine:mainfrom
many_for_each_mut with iter_many_mut.#5313tim-blackbird wants to merge 0 commit intobevyengine:mainfrom
Conversation
tim-blackbird
commented
Jul 13, 2022
crates/bevy_ecs/src/query/iter.rs
Outdated
| } | ||
|
|
||
| /// Get next result from the query | ||
| #[inline(always)] |
Contributor
Author
There was a problem hiding this comment.
I added #[inline(always)] to all next/fetch_next methods. Should I have?
115c5b4 to
71368d4
Compare
Contributor
Author
|
GitHub is now refusing to update this PR with changes I'm making to this branch. rip. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Huh, that's wierd. How did I manage to close this with a force push. and why did the force push yeet everything...
:l
Objective
Replace
many_for_each_mutwithiter_many_mutusing the same tricks to avoid aliased mutability thatiter_combinations_mutuses.Based on #5170.
View the changes for this PR here.
Why
many_for_each_mutis worse for a few reasons:continue,break, andreturnbehaves like a limitedcontinue.many_for_each_mutas a mutable counterpart toiter_manythaniter_many_mut.iter_many_mutAPI matches the existingiter_combinations_mutAPI.