Skip to content

[Merged by Bors] - SystemParam for the name of the system you are currently in#5731

Closed
Aceeri wants to merge 6 commits intobevyengine:mainfrom
Aceeri:system-name-param
Closed

[Merged by Bors] - SystemParam for the name of the system you are currently in#5731
Aceeri wants to merge 6 commits intobevyengine:mainfrom
Aceeri:system-name-param

Conversation

@Aceeri
Copy link
Member

@Aceeri Aceeri commented Aug 18, 2022

Objective

  • Similar to SystemChangeTick, probably somewhat useful for debugging messages.

Changelog

  • Added SystemName which copies the SystemMeta::name field so it can be accessed within a system.

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As demonstrated in #5497, this appears to be an attractive nuisance.

However, I still think we probably should still have it.

I'd suggest a few changes to make it more idiomatic.

@Weibye Weibye added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Aug 18, 2022
@cart
Copy link
Member

cart commented Aug 18, 2022

bors r+

bors bot pushed a commit that referenced this pull request Aug 18, 2022
# Objective
- Similar to `SystemChangeTick`, probably somewhat useful for debugging messages.

---

## Changelog

- Added `SystemName` which copies the `SystemMeta::name` field so it can be accessed within a system.
@bors
Copy link
Contributor

bors bot commented Aug 18, 2022

@bors bors bot changed the title SystemParam for the name of the system you are currently in [Merged by Bors] - SystemParam for the name of the system you are currently in Aug 18, 2022
@bors bors bot closed this Aug 18, 2022
inodentry pushed a commit to BroovyJammy/bevy that referenced this pull request Aug 19, 2022
…ne#5731)

# Objective
- Similar to `SystemChangeTick`, probably somewhat useful for debugging messages.

---

## Changelog

- Added `SystemName` which copies the `SystemMeta::name` field so it can be accessed within a system.
maccesch pushed a commit to Synphonyte/bevy that referenced this pull request Sep 28, 2022
…ne#5731)

# Objective
- Similar to `SystemChangeTick`, probably somewhat useful for debugging messages.

---

## Changelog

- Added `SystemName` which copies the `SystemMeta::name` field so it can be accessed within a system.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…ne#5731)

# Objective
- Similar to `SystemChangeTick`, probably somewhat useful for debugging messages.

---

## Changelog

- Added `SystemName` which copies the `SystemMeta::name` field so it can be accessed within a system.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…ne#5731)

# Objective
- Similar to `SystemChangeTick`, probably somewhat useful for debugging messages.

---

## Changelog

- Added `SystemName` which copies the `SystemMeta::name` field so it can be accessed within a system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants