[Merged by Bors] - Warning message for missing events#5730
Closed
Aceeri wants to merge 3 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Warning message for missing events#5730Aceeri wants to merge 3 commits intobevyengine:mainfrom
Aceeri wants to merge 3 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
Member
Author
|
Would be nice to have #5731 so we could tell the user which system is the offending reader of events. Could add it as a |
Member
with spans enabled, does the log have the system span? |
mockersf
reviewed
Aug 19, 2022
Member
Author
|
@mockersf I'm a bit confused, are we talking about the |
cart
approved these changes
Aug 30, 2022
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
Pretty sure the tracing spans would add the appropriate system context, where relevant. Happy to adjust as needed though with followups. For now, I think this is good to go!
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
# Objective - Reduce debugging burden when using events by telling user when they missed an event. ## Solution Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Reduce debugging burden when using events by telling user when they missed an event. ## Solution Co-authored-by: Carter Anderson <mcanders1@gmail.com>
This was referenced Nov 13, 2022
Closed
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
# Objective - Reverts #5730. - Fixes #6173, fixes #6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
# Objective - Reverts #5730. - Fixes #6173, fixes #6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
cart
pushed a commit
that referenced
this pull request
Nov 30, 2022
# Objective - Reverts #5730. - Fixes #6173, fixes #6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
archsolar
pushed a commit
to archsolar/bevy
that referenced
this pull request
Jan 20, 2023
…#6730) - Reverts bevyengine#5730. - Fixes bevyengine#6173, fixes bevyengine#6596. Remove the warning entirely. You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
archsolar
pushed a commit
to archsolar/bevy
that referenced
this pull request
Jan 20, 2023
…#6730) # Objective - Reverts bevyengine#5730. - Fixes bevyengine#6173, fixes bevyengine#6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Reduce debugging burden when using events by telling user when they missed an event. ## Solution Co-authored-by: Carter Anderson <mcanders1@gmail.com>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…#6730) # Objective - Reverts bevyengine#5730. - Fixes bevyengine#6173, fixes bevyengine#6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution