[Merged by Bors] - Remove warning about missed events due to false positives#6730
Closed
alice-i-cecile wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Remove warning about missed events due to false positives#6730alice-i-cecile wants to merge 1 commit intobevyengine:mainfrom
alice-i-cecile wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
Member
Author
|
This works. |
Contributor
|
This still leaves oldest_event_count and missed_events that were added in that PR. I think I'm ok with leaving them as they could potentially help with debugging issues that the warning was trying to prevent. |
hymm
approved these changes
Nov 22, 2022
james7132
added
the
S-Ready-For-Final-Review
|
Works for my general usecase. However I do think it is still a useful warning because it also helped me to pinpoint a bug that I would have missed in another case. |
nicopap
approved these changes
Nov 22, 2022
Contributor
nicopap
left a comment
nicopap
left a comment
There was a problem hiding this comment.
I personally only hit this warning as a false positive, but we could make an optional disable-able diagnostic plugin like in #5590. Of course, it doesn't help when it's off and you might not be able to remember to enable it when you start getting a weird issue this diagnostic is supposed to help you figure out. I'm not sure it would be any help in the end, therefore removing the diagnostic without an alternative seems fine.
Maybe some sort of "app stat" plugin could help.
Member
Author
|
Yeah, we can explore other designs for this very real problem later. bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
# Objective - Reverts #5730. - Fixes #6173, fixes #6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 23, 2022
# Objective - Reverts #5730. - Fixes #6173, fixes #6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
Contributor
bors
bot
changed the title
cart
pushed a commit
that referenced
this pull request
Nov 30, 2022
# Objective - Reverts #5730. - Fixes #6173, fixes #6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
archsolar
pushed a commit
to archsolar/bevy
that referenced
this pull request
Jan 20, 2023
…#6730) - Reverts bevyengine#5730. - Fixes bevyengine#6173, fixes bevyengine#6596. Remove the warning entirely. You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
archsolar
pushed a commit
to archsolar/bevy
that referenced
this pull request
Jan 20, 2023
…#6730) # Objective - Reverts bevyengine#5730. - Fixes bevyengine#6173, fixes bevyengine#6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…#6730) # Objective - Reverts bevyengine#5730. - Fixes bevyengine#6173, fixes bevyengine#6596. ## Solution Remove the warning entirely. ## Changelog You will no longer be spammed about > Missed 31 `bevy_input::mouse::MouseMotion` events. Consider reading from the `EventReader` more often (generally the best solution) or calling Events::update() less frequently (normally this is called once per frame). This problem is most likely due to run criteria/fixed timesteps or consuming events conditionally. See the Events documentation for more information. when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Remove the warning entirely.
Changelog
You will no longer be spammed about
when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using
ManualEventReader::missed_events